deardeng commented on code in PR #38388: URL: https://github.com/apache/doris/pull/38388#discussion_r1740777208
########## fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudClusterChecker.java: ########## @@ -371,22 +371,33 @@ private void getCloudObserverFes() { LOG.debug("get cloud cluster, clusterId={} nodes={}", Config.cloud_sql_server_cluster_id, cpb.getNodesList()); } - List<Frontend> currentFes = Env.getCurrentEnv().getFrontends(FrontendNodeType.OBSERVER); + List<Frontend> currentFollowers = Env.getCurrentEnv().getFrontends(FrontendNodeType.FOLLOWER); + List<Frontend> currentObservers = Env.getCurrentEnv().getFrontends(FrontendNodeType.OBSERVER); + currentFollowers.addAll(currentObservers); + List<Frontend> currentFes = new ArrayList<>(currentFollowers.stream().collect(Collectors.toMap( + fe -> fe.getHost() + ":" + fe.getEditLogPort(), + fe -> fe, + (existing, replacement) -> existing + )).values()); List<Frontend> toAdd = new ArrayList<>(); List<Frontend> toDel = new ArrayList<>(); List<Cloud.NodeInfoPB> expectedFes = cpb.getNodesList(); diffNodes(toAdd, toDel, () -> { + // memory Map<String, Frontend> currentMap = new HashMap<>(); String selfNode = Env.getCurrentEnv().getSelfNode().getIdent(); for (Frontend fe : currentFes) { String endpoint = fe.getHost() + "_" + fe.getEditLogPort(); if (selfNode.equals(endpoint)) { continue; } + // add type to map key, for diff + endpoint = endpoint + "_" + fe.getRole(); Review Comment: no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org