gavinchou commented on code in PR #40226:
URL: https://github.com/apache/doris/pull/40226#discussion_r1746694471
##########
be/src/io/cache/fs_file_cache_storage.cpp:
##########
@@ -159,7 +159,27 @@ Status FSFileCacheStorage::read(const FileCacheKey& key,
size_t value_offset, Sl
std::string file =
get_path_in_local_cache(get_path_in_local_cache(key.hash,
key.meta.expiration_time),
key.offset, key.meta.type);
- RETURN_IF_ERROR(fs->open_file(file, &file_reader));
+ Status s = fs->open_file(file, &file_reader);
+ if (!s.ok()) {
Review Comment:
NOT_FOUND
##########
be/src/io/cache/fs_file_cache_storage.cpp:
##########
@@ -347,6 +475,20 @@ void
FSFileCacheStorage::load_cache_info_into_memory(BlockFileCache* _mgr) const
auto f = [&](const BatchLoadArgs& args) {
// in async load mode, a cell may be added twice.
if (_mgr->_files.contains(args.hash) &&
_mgr->_files[args.hash].contains(args.offset)) {
+ /*
Review Comment:
remove instead of comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
