yiguolei commented on code in PR #40495:
URL: https://github.com/apache/doris/pull/40495#discussion_r1749466401
##########
be/src/vec/exec/scan/scanner_context.cpp:
##########
@@ -263,13 +272,19 @@ Status ScannerContext::get_block_from_queue(RuntimeState*
state, vectorized::Blo
block->swap(*current_block);
return_free_block(std::move(current_block));
} else {
+ // This scan task do not have any cached blocks.
_blocks_queue.pop_front();
- if (scan_task->is_eos()) { // current scanner is finished, and no
more data to read
+ // current scanner is finished, and no more data to read
+ if (scan_task->is_eos()) {
_num_finished_scanners++;
std::weak_ptr<ScannerDelegate> next_scanner;
// submit one of the remaining scanners
if (_scanners.try_dequeue(next_scanner)) {
- submit_scan_task(std::make_shared<ScanTask>(next_scanner));
+ auto scan_task_ptr =
std::make_shared<ScanTask>(next_scanner);
+ Status submit_status = submit_scan_task(scan_task_ptr);
+ if (!submit_status.ok()) {
+ append_block_to_queue_locked(scan_task_ptr, l);
Review Comment:
also should update the scanner context's status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
