github-actions[bot] commented on code in PR #40537:
URL: https://github.com/apache/doris/pull/40537#discussion_r1749648557
##########
be/src/util/block_compression.h:
##########
@@ -17,6 +17,7 @@
#pragma once
+#include <gen_cpp/PlanNodes_types.h>
Review Comment:
warning: 'gen_cpp/PlanNodes_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/PlanNodes_types.h>
^
```
##########
be/src/exec/decompressor.h:
##########
@@ -126,6 +137,25 @@ class Bzip2Decompressor : public Decompressor {
bz_stream _bz_strm;
};
+class ZstdDecompressor : public Decompressor {
+public:
+ ~ZstdDecompressor() override;
+
+ Status decompress(uint8_t* input, size_t input_len, size_t*
input_bytes_read, uint8_t* output,
+ size_t output_max_len, size_t* decompressed_len, bool*
stream_end,
+ size_t* more_input_bytes, size_t* more_output_bytes)
override;
+
+ std::string debug_info() override;
+
+private:
+ friend class Decompressor;
+ ZstdDecompressor() : Decompressor(CompressType::ZSTD) {}
+ Status init() override;
+
+private:
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/exec/decompressor.h:149:** previously declared here
```cpp
private:
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
