zclllyybb commented on code in PR #40695:
URL: https://github.com/apache/doris/pull/40695#discussion_r1764316975
##########
be/src/vec/functions/function_date_or_datetime_to_string.cpp:
##########
@@ -33,13 +33,18 @@ using FunctionMonthNameV2 =
FunctionDateOrDateTimeToString<MonthNameImpl<UInt32>
using FunctionDateTimeV2DayName =
FunctionDateOrDateTimeToString<DayNameImpl<UInt64>>;
using FunctionDateTimeV2MonthName =
FunctionDateOrDateTimeToString<MonthNameImpl<UInt64>>;
+using FunctionIso8601 = FunctionDateOrDateTimeToString<ToIso8601Impl<UInt32>>;
Review Comment:
dont need v1 anymore
##########
be/src/vec/functions/math.cpp:
##########
@@ -350,6 +350,74 @@ struct PowName {
};
using FunctionPow = FunctionBinaryArithmetic<PowImpl, PowName, false>;
+class FunctionNormalCdf : public IFunction {
+public:
+ static constexpr auto name = "normal_cdf";
+
+ String get_name() const override { return name; }
+
+ static FunctionPtr create() { return
std::make_shared<FunctionNormalCdf>(); }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return make_nullable(std::make_shared<DataTypeFloat64>());
+ }
+
+ DataTypes get_variadic_argument_types_impl() const override {
+ return {std::make_shared<DataTypeFloat64>(),
std::make_shared<DataTypeFloat64>(),
+ std::make_shared<DataTypeFloat64>()};
+ }
+ size_t get_number_of_arguments() const override { return 3; }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override
{
+ auto result_column = ColumnFloat64::create(input_rows_count);
+ auto result_null_map_column = ColumnUInt8::create(input_rows_count, 0);
+
+ auto& result_data = result_column->get_data();
+ NullMap& result_null_map =
+
assert_cast<ColumnUInt8*>(result_null_map_column.get())->get_data();
+
+ ColumnPtr argument_columns[3];
+ bool col_const[3];
+ size_t argument_size = arguments.size();
+ for (int i = 0; i < argument_size; ++i) {
+ argument_columns[i] = block.get_by_position(arguments[i]).column;
+ col_const[i] = is_column_const(*argument_columns[i]);
+ if (col_const[i]) {
+ argument_columns[i] =
+ static_cast<const
ColumnConst&>(*argument_columns[i]).get_data_column_ptr();
+ }
+ }
+
+ auto* mean_col = static_cast<const
ColumnFloat64*>(argument_columns[0].get());
+ auto* sd_col = static_cast<const
ColumnFloat64*>(argument_columns[1].get());
+ auto* value_col = static_cast<const
ColumnFloat64*>(argument_columns[2].get());
+
+ result_column->reserve(input_rows_count);
+ for (size_t i = 0; i < input_rows_count; ++i) {
+ double mean = mean_col->get_element(col_const[0] ? 0 : i);
+ double sd = sd_col->get_element(col_const[1] ? 0 : i);
+ double v = value_col->get_element(col_const[2] ? 0 : i);
+
+ if (!check_argument(sd)) {
Review Comment:
`unlikely`
##########
be/src/vec/functions/math.cpp:
##########
@@ -350,6 +350,74 @@ struct PowName {
};
using FunctionPow = FunctionBinaryArithmetic<PowImpl, PowName, false>;
+class FunctionNormalCdf : public IFunction {
+public:
+ static constexpr auto name = "normal_cdf";
+
+ String get_name() const override { return name; }
+
+ static FunctionPtr create() { return
std::make_shared<FunctionNormalCdf>(); }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return make_nullable(std::make_shared<DataTypeFloat64>());
+ }
+
+ DataTypes get_variadic_argument_types_impl() const override {
+ return {std::make_shared<DataTypeFloat64>(),
std::make_shared<DataTypeFloat64>(),
+ std::make_shared<DataTypeFloat64>()};
+ }
+ size_t get_number_of_arguments() const override { return 3; }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override
{
+ auto result_column = ColumnFloat64::create(input_rows_count);
+ auto result_null_map_column = ColumnUInt8::create(input_rows_count, 0);
+
+ auto& result_data = result_column->get_data();
+ NullMap& result_null_map =
+
assert_cast<ColumnUInt8*>(result_null_map_column.get())->get_data();
+
+ ColumnPtr argument_columns[3];
+ bool col_const[3];
+ size_t argument_size = arguments.size();
+ for (int i = 0; i < argument_size; ++i) {
+ argument_columns[i] = block.get_by_position(arguments[i]).column;
+ col_const[i] = is_column_const(*argument_columns[i]);
+ if (col_const[i]) {
+ argument_columns[i] =
+ static_cast<const
ColumnConst&>(*argument_columns[i]).get_data_column_ptr();
+ }
+ }
+
+ auto* mean_col = static_cast<const
ColumnFloat64*>(argument_columns[0].get());
Review Comment:
use `assert_cast` for them
##########
be/src/vec/functions/function_timestamp.cpp:
##########
@@ -1182,6 +1188,127 @@ class FunctionOtherTypesToDateType : public IFunction {
}
};
+struct FromIso8601DateV2 {
+ static constexpr auto name = "from_iso8601_date";
+
+ static size_t get_number_of_arguments() { return 1; }
+
+ static bool is_variadic() { return false; }
+
+ static DataTypes get_variadic_argument_types() { return
{std::make_shared<DataTypeString>()}; }
+
+ static DataTypePtr get_return_type_impl(const DataTypes& arguments) {
+ return make_nullable(std::make_shared<DataTypeDateV2>());
+ }
+
+ static Status execute(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) {
+ const auto* src_column_ptr =
block.get_by_position(arguments[0]).column.get();
+
+ auto null_map = ColumnUInt8::create(input_rows_count, 0);
+
+ ColumnPtr res = ColumnDateV2::create(input_rows_count);
+ auto& result_data =
static_cast<ColumnDateV2*>(res->assume_mutable().get())->get_data();
+
+ for (size_t i = 0; i < input_rows_count; ++i) {
+ std::string dash1, dash2;
+ int year, month, day, week, day_of_year;
+ int weekday = 1; // YYYYWww YYYY-Www default D = 1
+ auto iso_date =
re2::StringPiece(src_column_ptr->get_data_at(i).to_string_view());
+
+ auto& ts_value =
*reinterpret_cast<DateV2Value<DateV2ValueType>*>(&result_data[i]);
+ if (RE2::FullMatch(iso_date, CALENDAR_PATTERN, &year, &dash1,
&month, &dash2, &day)) {
Review Comment:
use regex for every cell may be inefficient. need more discuss
##########
be/src/vec/functions/function_timestamp.cpp:
##########
@@ -1182,6 +1188,127 @@ class FunctionOtherTypesToDateType : public IFunction {
}
};
+struct FromIso8601DateV2 {
+ static constexpr auto name = "from_iso8601_date";
+
+ static size_t get_number_of_arguments() { return 1; }
+
+ static bool is_variadic() { return false; }
+
+ static DataTypes get_variadic_argument_types() { return
{std::make_shared<DataTypeString>()}; }
+
+ static DataTypePtr get_return_type_impl(const DataTypes& arguments) {
+ return make_nullable(std::make_shared<DataTypeDateV2>());
+ }
+
+ static Status execute(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) {
+ const auto* src_column_ptr =
block.get_by_position(arguments[0]).column.get();
Review Comment:
assert_cast it. then `get_data_at` in loop will be devisualized
##########
be/src/vec/functions/function_timestamp.cpp:
##########
@@ -1182,6 +1188,127 @@ class FunctionOtherTypesToDateType : public IFunction {
}
};
+struct FromIso8601DateV2 {
+ static constexpr auto name = "from_iso8601_date";
+
+ static size_t get_number_of_arguments() { return 1; }
+
+ static bool is_variadic() { return false; }
+
+ static DataTypes get_variadic_argument_types() { return
{std::make_shared<DataTypeString>()}; }
+
+ static DataTypePtr get_return_type_impl(const DataTypes& arguments) {
+ return make_nullable(std::make_shared<DataTypeDateV2>());
+ }
+
+ static Status execute(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) {
+ const auto* src_column_ptr =
block.get_by_position(arguments[0]).column.get();
+
+ auto null_map = ColumnUInt8::create(input_rows_count, 0);
+
+ ColumnPtr res = ColumnDateV2::create(input_rows_count);
Review Comment:
using `ColumnDateV2::MutablePtr` as the type will make the next line easier
##########
be/src/vec/functions/math.cpp:
##########
@@ -350,6 +350,74 @@ struct PowName {
};
using FunctionPow = FunctionBinaryArithmetic<PowImpl, PowName, false>;
+class FunctionNormalCdf : public IFunction {
+public:
+ static constexpr auto name = "normal_cdf";
+
+ String get_name() const override { return name; }
+
+ static FunctionPtr create() { return
std::make_shared<FunctionNormalCdf>(); }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return make_nullable(std::make_shared<DataTypeFloat64>());
+ }
+
+ DataTypes get_variadic_argument_types_impl() const override {
+ return {std::make_shared<DataTypeFloat64>(),
std::make_shared<DataTypeFloat64>(),
+ std::make_shared<DataTypeFloat64>()};
+ }
+ size_t get_number_of_arguments() const override { return 3; }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override
{
+ auto result_column = ColumnFloat64::create(input_rows_count);
+ auto result_null_map_column = ColumnUInt8::create(input_rows_count, 0);
+
+ auto& result_data = result_column->get_data();
+ NullMap& result_null_map =
+
assert_cast<ColumnUInt8*>(result_null_map_column.get())->get_data();
+
+ ColumnPtr argument_columns[3];
+ bool col_const[3];
+ size_t argument_size = arguments.size();
+ for (int i = 0; i < argument_size; ++i) {
+ argument_columns[i] = block.get_by_position(arguments[i]).column;
+ col_const[i] = is_column_const(*argument_columns[i]);
+ if (col_const[i]) {
+ argument_columns[i] =
+ static_cast<const
ColumnConst&>(*argument_columns[i]).get_data_column_ptr();
+ }
+ }
+
+ auto* mean_col = static_cast<const
ColumnFloat64*>(argument_columns[0].get());
+ auto* sd_col = static_cast<const
ColumnFloat64*>(argument_columns[1].get());
+ auto* value_col = static_cast<const
ColumnFloat64*>(argument_columns[2].get());
+
+ result_column->reserve(input_rows_count);
+ for (size_t i = 0; i < input_rows_count; ++i) {
+ double mean = mean_col->get_element(col_const[0] ? 0 : i);
Review Comment:
just use `index_check_const`
##########
be/src/vec/functions/date_time_transforms.h:
##########
@@ -156,6 +156,29 @@ struct DayNameImpl {
}
};
+template <typename ArgType>
+struct ToIso8601Impl {
+ using OpArgType = ArgType;
+ static constexpr auto name = "to_iso8601";
+ static constexpr auto max_size = std::is_same_v<ArgType, UInt32> ? 10 : 26;
+
+ static inline auto execute(const typename DateTraits<ArgType>::T& dt,
+ ColumnString::Chars& res_data, size_t& offset) {
+ char buf[50];
+ auto length = dt.to_buffer(buf, std::is_same_v<ArgType, UInt32> ? -1 :
6);
+ if (std::is_same_v<ArgType, UInt64>) {
+ buf[10] = 'T';
+ }
+ memcpy(&res_data[offset], buf, length);
Review Comment:
directly write. dont copy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
