DongLiang-0 commented on code in PR #490:
URL: 
https://github.com/apache/doris-flink-connector/pull/490#discussion_r1764630256


##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/schema/SchemaChangeHelper.java:
##########
@@ -44,6 +44,7 @@ public class SchemaChangeHelper {
     private static final String CREATE_DATABASE_DDL = "CREATE DATABASE IF NOT 
EXISTS %s";
     private static final String MODIFY_TYPE_DDL = "ALTER TABLE %s MODIFY 
COLUMN %s %s";
     private static final String MODIFY_COMMENT_DDL = "ALTER TABLE %s MODIFY 
COLUMN %s COMMENT '%s'";
+    private static final String SHOW_FULL_COLUMN_DDL = "SHOW FULL COLUMNS FROM 
`%s`.`%s`";

Review Comment:
   Is this approach not universal?
   This sql seems to be the unique syntax of MySQL. If the upstream is Oracle 
or PostgreSQL, it will not be supported.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to