xiaokang commented on code in PR #40839:
URL: https://github.com/apache/doris/pull/40839#discussion_r1770273397
##########
be/src/vec/functions/array/function_array_aggregation.cpp:
##########
@@ -146,6 +146,18 @@ struct ArrayAggregateImpl {
using Function = AggregateFunction<AggregateFunctionImpl<operation>>;
const DataTypeArray* data_type_array =
static_cast<const
DataTypeArray*>(remove_nullable(arguments[0]).get());
+ if constexpr (operation == AggregateOperation::AVERAGE ||
Review Comment:
I think you shoud use witelist to check instead of blacklist, since if
someone add a new agg operation it passed by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
