github-actions[bot] commented on code in PR #41605:
URL: https://github.com/apache/doris/pull/41605#discussion_r1793167350
##########
be/src/runtime/runtime_state.h:
##########
@@ -450,6 +450,9 @@ class RuntimeState {
: 0;
}
+
+ bool is_nereids() const;
Review Comment:
warning: function 'is_nereids' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_nereids() const;
```
##########
be/src/runtime/query_context.h:
##########
@@ -222,12 +224,16 @@ class QueryContext {
public:
TUniqueId query_id;
DescriptorTbl* desc_tbl;
+
+ bool is_nereids() const { return _is_nereids; }
Review Comment:
warning: function 'is_nereids' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_nereids() const { return _is_nereids; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
