morrySnow commented on code in PR #41391:
URL: https://github.com/apache/doris/pull/41391#discussion_r1794570914
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/rpc/MetaServiceClient.java:
##########
@@ -79,7 +79,7 @@ private long connectionAgeExpiredAt() {
if (!isMetaServiceEndpointList && connectionAgeBase > 1) {
long base = TimeUnit.MINUTES.toMillis(connectionAgeBase);
long now = System.currentTimeMillis();
- long rand = random.nextLong(base);
+ long rand = random.nextLong() % base;
Review Comment:
already fixed, please rebase to newest master
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -565,6 +567,26 @@ public LogicalPlan
visitStatementDefault(StatementDefaultContext ctx) {
return withExplain(plan, ctx.explain());
}
+ @Override
+ public LogicalPlan
visitCreateScheduledJob(DorisParser.CreateScheduledJobContext ctx) {
+ Optional<String> label = ctx.label == null ? Optional.empty() :
Optional.of(ctx.label.getText());
+ Optional<String> atTime = ctx.atTime == null ? Optional.empty() :
Optional.of(ctx.atTime.getText());
+ Optional<Boolean> immediateStartOptional = ctx.CURRENT_TIMESTAMP() ==
null ? Optional.of(false) :
+ Optional.of(true);
+ Optional<String> startTime = ctx.startTime == null ? Optional.empty()
: Optional.of(ctx.startTime.getText());
+ Optional<String> endsTime = ctx.endsTime == null ? Optional.empty() :
Optional.of(ctx.endsTime.getText());
+ Optional<Long> interval = ctx.timeInterval == null ? Optional.empty() :
+ Optional.of(Long.valueOf(ctx.timeInterval.getText()));
+ Optional<String> intervalUnit = ctx.timeUnit == null ?
Optional.empty() : Optional.of(ctx.timeUnit.getText());
+ String commentSpec = ctx.commentSpec() == null ? "''" :
ctx.commentSpec().STRING_LITERAL().getText();
Review Comment:
could u have add override `visitCommentSpec`, let it return processed
comment string?
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -102,7 +103,17 @@ materializedViewStatement
| CANCEL MATERIALIZED VIEW TASK taskId=INTEGER_VALUE ON
mvName=multipartIdentifier #cancelMTMVTask
| SHOW CREATE MATERIALIZED VIEW mvName=multipartIdentifier
#showCreateMTMV
;
-
+jobScheduleStatement
+ : CREATE JOB label=multipartIdentifier ON SCHEDULE
Review Comment:
remove create job syntax in `sql_parser.cup` and remove `CreateJobStmt.java`
##########
regression-test/suites/job_p0/test_base_insert_job.groovy:
##########
@@ -26,6 +26,9 @@ suite("test_base_insert_job") {
def tableName = "t_test_BASE_inSert_job"
def jobName = "insert_recovery_test_base_insert_job"
def jobMixedName = "Insert_recovery_Test_base_insert_job"
+ sql """
+ SET enable_fallback_to_original_planner=false;
+ """
Review Comment:
this variable has been removed and u do not need to add it
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -102,7 +103,17 @@ materializedViewStatement
| CANCEL MATERIALIZED VIEW TASK taskId=INTEGER_VALUE ON
mvName=multipartIdentifier #cancelMTMVTask
| SHOW CREATE MATERIALIZED VIEW mvName=multipartIdentifier
#showCreateMTMV
;
-
+jobScheduleStatement
Review Comment:
```suggestion
supportedJobStatement
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
