HappenLee commented on code in PR #41623:
URL: https://github.com/apache/doris/pull/41623#discussion_r1794907940
##########
be/src/vec/columns/column_decimal.cpp:
##########
@@ -300,6 +300,16 @@ void ColumnDecimal<T>::insert_many_fix_len_data(const
char* data_ptr, size_t num
}
}
+template <typename T>
+void ColumnDecimal<T>::insert_many_from(const IColumn& src, size_t position,
size_t length) {
+ auto old_size = data.size();
+ data.resize(old_size + length);
+ auto& vals = assert_cast<const Self&>(src).get_data();
+ for (auto i = 0; i < length; ++i) {
Review Comment:
better use memcpy to do the work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
