github-actions[bot] commented on code in PR #41706:
URL: https://github.com/apache/doris/pull/41706#discussion_r1796576881
##########
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##########
@@ -110,7 +112,7 @@ Status HashJoinBuildSinkLocalState::open(RuntimeState*
state) {
return Status::OK();
}
-size_t HashJoinBuildSinkLocalState::get_reserve_mem_size(RuntimeState* state) {
+size_t HashJoinBuildSinkLocalState::get_reserve_mem_size(RuntimeState* state,
bool eos) {
Review Comment:
warning: method 'get_reserve_mem_size' can be made const
[readability-make-member-function-const]
be/src/pipeline/exec/hashjoin_build_sink.h:56:
```diff
- [[nodiscard]] size_t get_reserve_mem_size(RuntimeState* state, bool
eos);
+ [[nodiscard]] size_t get_reserve_mem_size(RuntimeState* state, bool
eos) const;
```
```suggestion
size_t HashJoinBuildSinkLocalState::get_reserve_mem_size(RuntimeState*
state, bool eos) const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
