github-actions[bot] commented on code in PR #41784:
URL: https://github.com/apache/doris/pull/41784#discussion_r1800417314
##########
be/src/olap/tablet.cpp:
##########
@@ -3342,74 +3395,145 @@ Status Tablet::generate_new_block_for_partial_update(
return Status::OK();
}
-// read columns by read plan
-// read_index: ori_pos-> block_idx
-Status Tablet::read_columns_by_plan(TabletSchemaSPtr tablet_schema,
- const std::vector<uint32_t> cids_to_read,
- const PartialUpdateReadPlan& read_plan,
- const std::map<RowsetId, RowsetSharedPtr>&
rsid_to_rowset,
- vectorized::Block& block,
- std::map<uint32_t, uint32_t>* read_index,
- const signed char* __restrict skip_map) {
- bool has_row_column = tablet_schema->store_row_column();
- auto mutable_columns = block.mutate_columns();
- size_t read_idx = 0;
- for (auto rs_it : read_plan) {
- for (auto seg_it : rs_it.second) {
- auto rowset_iter = rsid_to_rowset.find(rs_it.first);
- CHECK(rowset_iter != rsid_to_rowset.end());
- std::vector<uint32_t> rids;
- for (auto [rid, pos] : seg_it.second) {
- if (skip_map && skip_map[pos]) {
- continue;
- }
- rids.emplace_back(rid);
- (*read_index)[pos] = read_idx++;
+Status Tablet::generate_new_block_for_flexible_partial_update(
Review Comment:
warning: function 'generate_new_block_for_flexible_partial_update' exceeds
recommended size/complexity thresholds [readability-function-size]
```cpp
();
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/tablet.cpp:3397:** 134 lines including whitespace and comments
(threshold 80)
```cpp
();
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
