zhiqiang-hhhh commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1801019820
##########
be/src/vec/functions/array/function_array_range.cpp:
##########
@@ -146,14 +144,6 @@ struct RangeImplUtil {
for (int i = 0; i < 3; ++i) {
argument_columns[i] =
block.get_by_position(arguments[i]).column->convert_to_full_column_if_const();
- if (auto* nullable =
check_and_get_column<ColumnNullable>(*argument_columns[i])) {
- // Danger: Here must dispose the null map data first! Because
- // argument_columns[i]=nullable->get_nested_column_ptr(); will
release the mem
- // of column nullable mem of null map
- VectorizedUtils::update_null_map(args_null_map->get_data(),
Review Comment:
`arg_null_map` was updated in this line, and was used be code after this
line, then you removed this logic. Why does this function still work?
##########
be/src/vec/functions/array/function_array_enumerate.cpp:
##########
@@ -56,7 +56,6 @@ class FunctionArrayEnumerate : public IFunction {
static constexpr auto name = "array_enumerate";
static FunctionPtr create() { return
std::make_shared<FunctionArrayEnumerate>(); }
String get_name() const override { return name; }
- bool use_default_implementation_for_nulls() const override { return true; }
Review Comment:
do not modify code like this if this pr just wants to do refactor on
`check_set_nullable`
##########
be/src/vec/functions/array/function_array_contains_all.cpp:
##########
@@ -37,8 +37,6 @@ class FunctionArrayContainsAll : public IFunction {
String get_name() const override { return name; }
- bool use_default_implementation_for_nulls() const override { return true; }
Review Comment:
do not modify code like this if this pr just wants to do refactor on
`check_set_nullable`
##########
be/src/vec/functions/function_bitmap.cpp:
##########
@@ -349,8 +349,6 @@ class FunctionBitmapAlwaysNull : public IFunction {
size_t get_number_of_arguments() const override { return 1; }
- bool use_default_implementation_for_nulls() const override { return true; }
Review Comment:
keep this, just focus on `check_set_nullable`
##########
be/src/vec/functions/function_bitmap.cpp:
##########
@@ -1168,10 +1164,6 @@ class FunctionBitmapSubs : public IFunction {
default_preprocess_parameter_columns(argument_columns, col_const, {1,
2}, block, arguments);
- for (int i = 0; i < 3; i++) {
Review Comment:
same problem with `RangeImplUtil`, it seems you remove some update logic to
`res_null_map`, but actually `res_null_map` is still being used in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
