morningman commented on code in PR #41992:
URL: https://github.com/apache/doris/pull/41992#discussion_r1808011988
##########
regression-test/conf/regression-conf.groovy:
##########
@@ -233,7 +233,7 @@ max_failure_num=0
// used for exporting test
s3ExportBucketName = ""
-externalEnvIp="127.0.0.1"
+externalEnvIp="43.129.201.77"
Review Comment:
no need to change this
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/client/JdbcClient.java:
##########
@@ -152,8 +163,7 @@ private void initializeDataSource(JdbcClientConfig config) {
private void initializeClassLoader(JdbcClientConfig config) {
try {
URL[] urls = {new
URL(JdbcResource.getFullDriverUrl(config.getDriverUrl()))};
- ClassLoader parent = getClass().getClassLoader();
- this.classLoader = URLClassLoader.newInstance(urls, parent);
+ this.classLoader = URLClassLoader.newInstance(urls);
Review Comment:
Why removing the `parent`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
