HappenLee commented on code in PR #41968:
URL: https://github.com/apache/doris/pull/41968#discussion_r1808508222
##########
be/src/pipeline/exec/exchange_sink_buffer.cpp:
##########
@@ -470,18 +424,13 @@ bool ExchangeSinkBuffer::_is_receiver_eof(InstanceLoId
id) {
return _instance_to_receiver_eof[id];
}
-void ExchangeSinkBuffer::_turn_off_channel(InstanceLoId id, bool cleanup) {
+void ExchangeSinkBuffer::_turn_off_channel(InstanceLoId id) {
Review Comment:
if we call the function, we must get the lock of
`std::unique_lock<std::mutex> lock(*_instance_to_package_queue_mutex[id]);` so
better we can read the important msg from comment or function name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
