zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1814335826
##########
be/src/vec/functions/function_cast.h:
##########
@@ -651,7 +651,7 @@ struct ConvertImplNumberToJsonb {
} else if constexpr (std::is_same_v<ColumnFloat64, ColumnType>) {
writer.writeDouble(data[i]);
} else {
- LOG(FATAL) << "unsupported type ";
+ throw Exception(Status::NotSupported("unsupported type "));
Review Comment:
for `if constexpr`, you can use `static_assert` rather than `throw`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
