zhannngchen commented on code in PR #42379:
URL: https://github.com/apache/doris/pull/42379#discussion_r1815931095
##########
be/src/cloud/config.cpp:
##########
@@ -75,4 +75,6 @@ DEFINE_mInt32(tablet_txn_info_min_expired_seconds, "120");
DEFINE_mBool(enable_use_cloud_unique_id_from_fe, "true");
+DEFINE_mBool(enable_cloud_delete_old_version_delete_bitmap, "false");
Review Comment:
`enable_cleanup_delete_bitmap_on_compaction`
don't need to specify `cloud` in the config name, since we also support this
feature on non-cloud env(another PR)
##########
be/src/cloud/cloud_cumulative_compaction.cpp:
##########
@@ -405,6 +411,20 @@ void
CloudCumulativeCompaction::process_old_version_delete_bitmap() {
cloud_tablet()->tablet_id());
});
if (update_st.ok()) {
+ std::vector<std::tuple<std::string, uint64_t, uint64_t>>
to_delete;
+ for (auto it = new_delete_bitmap->delete_bitmap.begin();
+ it != new_delete_bitmap->delete_bitmap.end(); it++) {
+
to_delete.emplace_back(std::make_tuple(std::get<0>(it->first).to_string(),
+
std::get<2>(it->first),
+
std::get<2>(it->first)));
+ }
+ auto st =
_engine.meta_mgr().remove_old_version_delete_bitmap(_tablet->tablet_id(),
Review Comment:
You shoud do the remove operation in the same FDB transaction with the
update operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
