eldenmoon commented on code in PR #42416:
URL: https://github.com/apache/doris/pull/42416#discussion_r1818300839
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -642,11 +642,18 @@ public static Set<String>
analyzeBloomFilterColumns(Map<String, String> properti
if (column.getName().equalsIgnoreCase(bfColumn)) {
PrimitiveType type = column.getDataType();
- // tinyint/float/double columns don't support
+ // now we only support BloomFilter on (same behavior
with BE):
+ // smallint/int/bigint/largeint
+ // string/varchar/char/variant
+ // date/datetime/datev2/datetimev2
+ // decimal/decimal32/decimal64/decimal128I/decimal256
+ // ipv4/ipv6
+ //
// key columns and none/replace aggregate non-key
columns support
- if (type == PrimitiveType.TINYINT || type ==
PrimitiveType.FLOAT
- || type == PrimitiveType.DOUBLE || type ==
PrimitiveType.BOOLEAN
- || type.isComplexType()) {
+ if (!((type == PrimitiveType.SMALLINT || type ==
PrimitiveType.INT
Review Comment:
maybe add a function isSupportedBloomFilter(PrimitiveType type)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
