zhannngchen commented on code in PR #41759:
URL: https://github.com/apache/doris/pull/41759#discussion_r1822109481
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java:
##########
@@ -637,7 +639,13 @@ private void calcDeleteBitmapForMow(long dbId,
List<OlapTable> tableList, long t
Map<Long, List<TCalcDeleteBitmapPartitionInfo>>
backendToPartitionInfos = getCalcDeleteBitmapInfo(
backendToPartitionTablets, partitionVersions,
baseCompactionCnts, cumulativeCompactionCnts,
cumulativePoints);
- sendCalcDeleteBitmaptask(dbId, transactionId, backendToPartitionInfos);
+ try {
+ sendCalcDeleteBitmaptask(dbId, transactionId,
backendToPartitionInfos);
+ } catch (UserException e) {
+ LOG.warn("failed to sendCalcDeleteBitmaptask for txn=" +
transactionId + ",exception=" + e);
Review Comment:
use `e.getMessage()`
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -1640,8 +1640,8 @@ void
MetaServiceImpl::get_tablet_stats(::google::protobuf::RpcController* contro
static bool check_delete_bitmap_lock(MetaServiceCode& code, std::string& msg,
std::stringstream& ss,
std::unique_ptr<Transaction>& txn,
std::string& instance_id,
- int64_t table_id, int64_t lock_id,
int64_t lock_initiator) {
- std::string lock_key = meta_delete_bitmap_update_lock_key({instance_id,
table_id, -1});
Review Comment:
you should change it at #40431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
