xiaokang commented on code in PR #42680:
URL: https://github.com/apache/doris/pull/42680#discussion_r1825314460
##########
be/src/olap/rowset/segment_v2/options.h:
##########
@@ -25,6 +25,7 @@ namespace segment_v2 {
static constexpr size_t DEFAULT_PAGE_SIZE = 1024 * 1024; // default size: 1M
constexpr long ROW_STORE_PAGE_SIZE_DEFAULT_VALUE = 16384; // default row store
page size: 16KB
+static constexpr int64_t STORAGE_PAGE_SIZE_DEFAULT_VALUE = 65536;
Review Comment:
There are three types for XX_PAGE_SIZE: size_t, long, int64_t. We should use
consistent type.
```
static constexpr size_t DEFAULT_PAGE_SIZE = 1024 * 1024; // default size: 1M
constexpr long ROW_STORE_PAGE_SIZE_DEFAULT_VALUE = 16384; // default row
store page size: 16KB
static constexpr int64_t STORAGE_PAGE_SIZE_DEFAULT_VALUE = 65536;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
