github-actions[bot] commented on code in PR #43144:
URL: https://github.com/apache/doris/pull/43144#discussion_r1826579449
##########
be/src/vec/exec/scan/scanner_scheduler.cpp:
##########
@@ -385,4 +376,38 @@ int ScannerScheduler::get_remote_scan_thread_queue_size() {
return config::doris_remote_scanner_thread_pool_queue_size;
}
+// The name of these varialbs will be useds as metric name in prometheus.
+DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(scan_scheduler_running_tasks,
MetricUnit::NOUNIT);
+DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(scan_scheduler_queue_size,
MetricUnit::NOUNIT);
+DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(scan_scheduler_queue_capacity,
MetricUnit::NOUNIT);
+DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(scan_scheduler_max_thread_number,
MetricUnit::NOUNIT);
+
+SimplifiedScanScheduler::SimplifiedScanScheduler(std::string sched_name,
CgroupCpuCtl* cg_cpu_ctl)
Review Comment:
warning: pass by value and use std::move [modernize-pass-by-value]
be/src/vec/exec/scan/scanner_scheduler.cpp:385:
```diff
- : _is_stop(false), _cgroup_cpu_ctl(cg_cpu_ctl),
_sched_name(sched_name) {
+ : _is_stop(false), _cgroup_cpu_ctl(cg_cpu_ctl),
_sched_name(std::move(sched_name)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
