github-actions[bot] commented on code in PR #43218:
URL: https://github.com/apache/doris/pull/43218#discussion_r1827491111
##########
be/src/vec/exprs/table_function/table_function.h:
##########
@@ -18,13 +18,15 @@
#pragma once
#include <fmt/core.h>
Review Comment:
warning: 'fmt/core.h' file not found [clang-diagnostic-error]
```cpp
#include <fmt/core.h>
^
```
##########
be/src/vec/exprs/vcompound_pred.h:
##########
@@ -18,18 +18,21 @@
#pragma once
#include <gen_cpp/Opcodes_types.h>
Review Comment:
warning: 'gen_cpp/Opcodes_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/Opcodes_types.h>
^
```
##########
be/src/vec/exprs/vectorized_agg_fn.h:
##########
@@ -17,8 +17,8 @@
#pragma once
#include <gen_cpp/Types_types.h>
Review Comment:
warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/Types_types.h>
^
```
##########
be/src/vec/exprs/table_function/vexplode_json_array.h:
##########
@@ -20,21 +20,19 @@
#include <glog/logging.h>
Review Comment:
warning: 'glog/logging.h' file not found [clang-diagnostic-error]
```cpp
#include <glog/logging.h>
^
```
##########
be/src/vec/functions/function.h:
##########
@@ -22,10 +22,9 @@
#include <fmt/format.h>
Review Comment:
warning: 'fmt/format.h' file not found [clang-diagnostic-error]
```cpp
#include <fmt/format.h>
^
```
##########
be/src/util/simd/bits.h:
##########
@@ -27,8 +28,7 @@
#include "util/sse_util.hpp"
Review Comment:
warning: 'util/sse_util.hpp' file not found [clang-diagnostic-error]
```cpp
#include "util/sse_util.hpp"
^
```
##########
be/src/vec/functions/array/function_array_index.h:
##########
@@ -348,7 +348,7 @@ class FunctionArrayIndex : public IFunction {
return nullptr;
}
- Status _execute_dispatch(Block& block, const ColumnNumbers& arguments,
size_t result,
+ Status _execute_dispatch(Block& block, const ColumnNumbers& arguments,
uint32_t result,
Review Comment:
warning: function '_execute_dispatch' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
Status _execute_dispatch(Block& block, const ColumnNumbers& arguments,
uint32_t result,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/functions/array/function_array_index.h:350:** 136 lines
including whitespace and comments (threshold 80)
```cpp
Status _execute_dispatch(Block& block, const ColumnNumbers& arguments,
uint32_t result,
^
```
</details>
##########
be/src/vec/exprs/vectorized_fn_call.h:
##########
@@ -17,12 +17,10 @@
#pragma once
#include <gen_cpp/Types_types.h>
Review Comment:
warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/Types_types.h>
^
```
##########
be/src/vec/functions/function_date_or_datetime_computation.h:
##########
@@ -536,7 +536,7 @@
template <typename FromType1, typename Transform, typename FromType2 =
FromType1>
struct DateTimeAddIntervalImpl {
- static Status execute(Block& block, const ColumnNumbers& arguments, size_t
result,
+ static Status execute(Block& block, const ColumnNumbers& arguments,
uint32_t result,
Review Comment:
warning: function 'execute' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
static Status execute(Block& block, const ColumnNumbers& arguments,
uint32_t result,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/functions/function_date_or_datetime_computation.h:538:** 151
lines including whitespace and comments (threshold 80)
```cpp
static Status execute(Block& block, const ColumnNumbers& arguments,
uint32_t result,
^
```
</details>
##########
be/src/vec/functions/function_date_or_datetime_computation.h:
##########
@@ -536,7 +536,7 @@ struct DateTimeOp {
template <typename FromType1, typename Transform, typename FromType2 =
FromType1>
struct DateTimeAddIntervalImpl {
- static Status execute(Block& block, const ColumnNumbers& arguments, size_t
result,
+ static Status execute(Block& block, const ColumnNumbers& arguments,
uint32_t result,
Review Comment:
warning: function 'execute' has cognitive complexity of 61 (threshold 50)
[readability-function-cognitive-complexity]
```cpp
static Status execute(Block& block, const ColumnNumbers& arguments,
uint32_t result,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/functions/function_date_or_datetime_computation.h:545:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (const auto* sources =
check_and_get_column<ColumnVector<FromType1>>(source_col.get())) {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:550:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (is_nullable) {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:552:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (const auto* delta_const_column =
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:554:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if (delta_const_column->get_field().get_type() ==
Field::Types::Int128) {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:558:** +1,
nesting level increased to 4
```cpp
} else if (delta_const_column->get_field().get_type() ==
Field::Types::Int64) {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:562:** +1,
nesting level increased to 4
```cpp
} else if (delta_const_column->get_field().get_type() ==
Field::Types::UInt64) {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:566:** +1,
nesting level increased to 4
```cpp
} else {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:571:** +1,
nesting level increased to 3
```cpp
} else {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:572:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if (const auto* delta_vec_column0 =
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:576:** +1,
nesting level increased to 4
```cpp
} else {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:584:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (const auto* nullable_col =
check_and_get_column<ColumnNullable>(
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:593:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (const auto* nullable_col =
check_and_get_column<ColumnNullable>(
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:604:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:605:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (const auto* delta_const_column =
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:607:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if (delta_const_column->get_field().get_type() ==
Field::Types::Int128) {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:610:** +1,
nesting level increased to 4
```cpp
} else if (delta_const_column->get_field().get_type() ==
Field::Types::Int64) {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:613:** +1,
nesting level increased to 4
```cpp
} else if (delta_const_column->get_field().get_type() ==
Field::Types::UInt64) {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:616:** +1,
nesting level increased to 4
```cpp
} else {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:620:** +1,
nesting level increased to 3
```cpp
} else {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:621:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if (const auto* delta_vec_column0 =
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:625:** +1,
nesting level increased to 4
```cpp
} else {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:635:** +1,
nesting level increased to 1
```cpp
} else if (const auto* sources_const =
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:638:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (is_nullable) {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:642:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (const auto* delta_vec_column =
check_and_get_column<ColumnVector<FromType2>>(
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:647:** +1,
nesting level increased to 3
```cpp
} else {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:652:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (const auto* nullable_col =
check_and_get_column<ColumnNullable>(
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:661:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (const auto* nullable_col =
check_and_get_column<ColumnNullable>(
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:672:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:673:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (const auto* delta_vec_column =
check_and_get_column<ColumnVector<FromType2>>(
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:677:** +1,
nesting level increased to 3
```cpp
} else {
^
```
**be/src/vec/functions/function_date_or_datetime_computation.h:684:** +1,
nesting level increased to 1
```cpp
} else {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
