hubgeter commented on code in PR #41752:
URL: https://github.com/apache/doris/pull/41752#discussion_r1828025147
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Suite.groovy:
##########
@@ -2127,7 +2127,7 @@ class Suite implements GroovyInterceptable {
def js = jsonOutput.toJson(map)
log.info("get be metric req: ${js} ".toString())
- def ret = 0;
+ def ret = Integer.MAX_VALUE
Review Comment:
I am worried that it will affect other existing test cases, so I do not
recommend making this change. Is it possible to loop through some test cases in
`test_be_metrics.groovy` and terminate the loop if one of them meets
expectations? At least this way, you don't have to change other existing test
cases.
Like this :
```
bool haveValue = false;
for ( xxxx ){
if ( check(xxx) ) {
haveValue = true;
break;
}
Thread.sleep( xxx )
}
assertTrue (haveValue)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
