eldenmoon commented on code in PR #43480:
URL: https://github.com/apache/doris/pull/43480#discussion_r1833762154
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -192,8 +192,19 @@ Status SegmentWriter::_create_column_writer(uint32_t cid,
const TabletColumn& co
if (tablet_index) {
opts.need_bloom_filter = true;
opts.is_ngram_bf_index = true;
- opts.gram_size = tablet_index->get_gram_size();
- opts.gram_bf_size = tablet_index->get_gram_bf_size();
+ //narrow convert from int32_t to uint8_t and uint16_t which is
dangerous
+ auto gram_size = tablet_index->get_gram_size();
+ auto gram_bf_size = tablet_index->get_gram_bf_size();
+ if (gram_size > 256 || gram_size < 1) {
+ return Status::NotSupported("Do not support ngram bloom filter for
ngram_size: ",
Review Comment:
why not check gram in FE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
