csun5285 commented on code in PR #43375:
URL: https://github.com/apache/doris/pull/43375#discussion_r1834157807
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -186,8 +186,9 @@ Status SegmentWriter::_create_column_writer(uint32_t cid,
const TabletColumn& co
// now we create zone map for key columns in AGG_KEYS or all column in
UNIQUE_KEYS or DUP_KEYS
// except for columns whose type don't support zone map.
- opts.need_zone_map = column.is_key() || schema->keys_type() !=
KeysType::AGG_KEYS;
- opts.need_bloom_filter = column.is_bf_column();
+ opts.need_zone_map = (column.is_key() || schema->keys_type() !=
KeysType::AGG_KEYS) &&
Review Comment:
Line 221 will not check the variant column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
