w41ter commented on code in PR #41167:
URL: https://github.com/apache/doris/pull/41167#discussion_r1835904442
##########
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java:
##########
@@ -1576,7 +1576,9 @@ public void logTableRename(TableInfo tableInfo) {
}
public void logModifyViewDef(AlterViewInfo alterViewInfo) {
- logEdit(OperationType.OP_MODIFY_VIEW_DEF, alterViewInfo);
+ long logId = logEdit(OperationType.OP_MODIFY_VIEW_DEF, alterViewInfo);
+ LOG.info("log modify view, logId : {}, infos: {}", logId,
alterViewInfo);
Review Comment:
Change this log level to debug, since the output of `AlterViewInfo` might be
huge.
##########
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java:
##########
@@ -1576,7 +1576,9 @@ public void logTableRename(TableInfo tableInfo) {
}
public void logModifyViewDef(AlterViewInfo alterViewInfo) {
- logEdit(OperationType.OP_MODIFY_VIEW_DEF, alterViewInfo);
+ long logId = logEdit(OperationType.OP_MODIFY_VIEW_DEF, alterViewInfo);
+ LOG.info("log modify view, logId : {}, infos: {}", logId,
alterViewInfo);
+ Env.getCurrentEnv().getBinlogManager().addModifyViewDef(alterViewInfo,
logId);
Review Comment:
In the replaying stage, the binlog must also be added to the binlog manager.
The relevant code is in `loadJournal()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
