github-actions[bot] commented on code in PR #43590:
URL: https://github.com/apache/doris/pull/43590#discussion_r1836036269
##########
be/src/io/fs/s3_file_bufferpool.cpp:
##########
@@ -110,8 +112,14 @@ Status UploadFileBuffer::append_data(const Slice& data) {
*/
static Status submit_upload_buffer(std::shared_ptr<FileBuffer> buffer) {
TEST_SYNC_POINT_RETURN_WITH_VALUE("UploadFileBuffer::submit",
Status::OK(), buffer.get());
- return ExecEnv::GetInstance()->s3_file_upload_thread_pool()->submit_func(
- [buf = std::move(buffer)]() { buf->execute_async(); });
+ auto pool = ExecEnv::GetInstance()->s3_file_upload_thread_pool();
Review Comment:
warning: 'auto pool' can be declared as 'auto *pool'
[readability-qualified-auto]
```suggestion
auto *pool = ExecEnv::GetInstance()->s3_file_upload_thread_pool();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
