wangshuo128 commented on code in PR #9459:
URL: https://github.com/apache/incubator-doris/pull/9459#discussion_r867666484
##########
be/src/olap/memtable.h:
##########
@@ -195,9 +199,11 @@ class MemTable {
//for vectorized
vectorized::MutableBlock _input_mutable_block;
vectorized::MutableBlock _output_mutable_block;
- vectorized::Block _collect_vskiplist_results();
+ void _collect_vskiplist_to_output(bool final);
Review Comment:
nit: cpp has `final` keyword, it's better to use another name, maybe
`is_final`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
