CalvinKirs commented on code in PR #43636:
URL: https://github.com/apache/doris/pull/43636#discussion_r1838191519
##########
fe/fe-common/pom.xml:
##########
@@ -145,6 +145,12 @@ under the License.
<groupId>com.esotericsoftware</groupId>
<artifactId>kryo-shaded</artifactId>
</dependency>
+ <dependency>
+ <groupId>commons-collections</groupId>
+ <artifactId>commons-collections</artifactId>
+ <version>${commons-collections.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Since commons-related dependencies are fundamental, it’s best not to
categorize them as test dependencies. Doing so could lead to issues when adding
new dependencies later on, especially if they have transitive dependencies on
commons-collections. Also, it looks like this PR doesn’t actually use
commons-collections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
