HappenLee commented on code in PR #43050:
URL: https://github.com/apache/doris/pull/43050#discussion_r1839733400
##########
be/src/vec/data_types/data_type_number_base.h:
##########
@@ -188,12 +189,12 @@ class DataTypeNumberBase : public IDataType {
for (int row_num = 0; row_num < size; row_num++) {
auto num = is_const ? col_vec.get_element(0) :
col_vec.get_element(row_num);
static_cast<const Derived*>(this)->push_number(chars, num);
- offsets[row_num] = chars.size();
+ offsets[row_num] = cast_set<UInt32>(chars.size());
Review Comment:
seems we only need static_cast? push_number can check the chars is over
uint32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
