This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new a519702fac4 branch-2.1: [Bug](bitmap-filter) fix wrong type cast on
BitmapFilterColumnPredicate::evaluate #43877 (#43886)
a519702fac4 is described below
commit a519702fac4c25c4f9da30a632b6b2fb6c894598
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Fri Nov 15 00:02:51 2024 +0800
branch-2.1: [Bug](bitmap-filter) fix wrong type cast on
BitmapFilterColumnPredicate::evaluate #43877 (#43886)
Cherry-picked from #43877
Co-authored-by: Pxl <[email protected]>
---
be/src/olap/bitmap_filter_predicate.h | 2 +-
be/test/olap/bitmap_filter_column_predicate_test.cpp | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/be/src/olap/bitmap_filter_predicate.h
b/be/src/olap/bitmap_filter_predicate.h
index 7075595e66e..ed5a7d35403 100644
--- a/be/src/olap/bitmap_filter_predicate.h
+++ b/be/src/olap/bitmap_filter_predicate.h
@@ -42,7 +42,7 @@ public:
const std::shared_ptr<BitmapFilterFuncBase>&
filter, int)
: ColumnPredicate(column_id),
_filter(filter),
- _specific_filter(static_cast<SpecificFilter*>(_filter.get())) {}
+ _specific_filter(assert_cast<SpecificFilter*>(_filter.get())) {}
~BitmapFilterColumnPredicate() override = default;
PredicateType type() const override { return PredicateType::BITMAP_FILTER;
}
diff --git a/be/test/olap/bitmap_filter_column_predicate_test.cpp
b/be/test/olap/bitmap_filter_column_predicate_test.cpp
index 2f97704de50..c8845787e9a 100644
--- a/be/test/olap/bitmap_filter_column_predicate_test.cpp
+++ b/be/test/olap/bitmap_filter_column_predicate_test.cpp
@@ -128,7 +128,7 @@ TEST_F(BitmapFilterColumnPredicateTest, evaluate_column) {
bitmap_value.add_many(filter_values.data(), filter_values.size());
filter->insert(&bitmap_value);
- auto column = vectorized::ColumnInt32::create();
+ auto column = vectorized::PredicateColumnType<TYPE_INT>::create();
column->insert_many_fix_len_data(reinterpret_cast<const
char*>(values.data()), values.size());
uint16_t* sel = new uint16_t[column->size()];
@@ -162,7 +162,7 @@ TEST_F(BitmapFilterColumnPredicateTest,
evaluate_column_nullable) {
bitmap_value.add_many(filter_values.data(), filter_values.size());
filter->insert(&bitmap_value);
- auto column = vectorized::ColumnInt32::create();
+ auto column = vectorized::PredicateColumnType<TYPE_INT>::create();
column->insert_many_fix_len_data(reinterpret_cast<const
char*>(values.data()), values.size());
auto flag = vectorized::ColumnUInt8::create();
flag->insert_many_defaults(column->size());
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
