amorynan commented on code in PR #43926:
URL: https://github.com/apache/doris/pull/43926#discussion_r1843123952
##########
be/src/vec/columns/column_dictionary.h:
##########
@@ -158,10 +158,6 @@ class ColumnDictionary final : public COWHelper<IColumn,
ColumnDictionary<T>> {
__builtin_unreachable();
}
- bool is_fixed_and_contiguous() const override { return true; }
Review Comment:
is this can be deleted ?
because get_raw_data() maybe depends on it?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
