zzzxl1993 commented on code in PR #43643:
URL: https://github.com/apache/doris/pull/43643#discussion_r1843144620
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/ApproxTopK.java:
##########
@@ -55,9 +55,19 @@ public ApproxTopK(boolean distinct, boolean alwaysNullable,
Expression... varArg
@Override
public void checkLegalityBeforeTypeCoercion() {
- if (arity() < 1) {
+ if (arity() < 3) {
Review Comment:
The existing function framework code cannot implement approx_top_k and
approx_top_sum with default values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
