HappenLee commented on code in PR #43939:
URL: https://github.com/apache/doris/pull/43939#discussion_r1844918438
##########
be/src/vec/columns/column.h:
##########
@@ -503,13 +503,17 @@ class IColumn : public COW<IColumn> {
/** Split column to smaller columns. Each value goes to column index,
selected by corresponding element of 'selector'.
* Selector must contain values from 0 to num_columns - 1.
- * For default implementation, see scatter_impl.
+ * For default implementation, see column_impl.h
*/
using ColumnIndex = UInt64;
using Selector = PaddedPODArray<ColumnIndex>;
+ // The append_data_by_selector function requires the column to implement
the insert_from function.
+ // In fact, this function is just calling insert_from but without the
overhead of a virtual function.
+
Review Comment:
remove the useless space line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
