github-actions[bot] commented on code in PR #44098:
URL: https://github.com/apache/doris/pull/44098#discussion_r1846925743
##########
be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:
##########
@@ -445,7 +437,7 @@ Status RowGroupReader::_read_column_data(Block* block,
const std::vector<std::st
Status RowGroupReader::_do_lazy_read(Block* block, size_t batch_size, size_t*
read_rows,
Review Comment:
warning: function '_do_lazy_read' has cognitive complexity of 92 (threshold
50) [readability-function-cognitive-complexity]
```cpp
Status RowGroupReader::_do_lazy_read(Block* block, size_t batch_size,
size_t* read_rows,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:445:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
for (uint32_t i = 0; i < origin_column_num; ++i) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:450:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
while (!_state->is_cancelled()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:455:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_read_column_data(block,
_lazy_read_ctx.predicate_columns.first, batch_size,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:455:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_read_column_data(block,
_lazy_read_ctx.predicate_columns.first, batch_size,
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:457:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (pre_read_rows == 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:462:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_fill_partition_columns(block, pre_read_rows,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:462:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_fill_partition_columns(block, pre_read_rows,
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:464:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_fill_missing_columns(block, pre_read_rows,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:464:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_fill_missing_columns(block, pre_read_rows,
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:467:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_build_pos_delete_filter(pre_read_rows));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:467:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_build_pos_delete_filter(pre_read_rows));
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:470:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (_lazy_read_ctx.resize_first_column) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:478:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (_position_delete_ctx.has_filter) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:489:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(VExprContext::execute_conjuncts(filter_contexts,
&filters, block,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:489:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(VExprContext::execute_conjuncts(filter_contexts,
&filters, block,
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:493:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (_lazy_read_ctx.resize_first_column) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:500:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(filter_map_ptr->init(filter_map_data, pre_read_rows,
can_filter_all));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:500:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(filter_map_ptr->init(filter_map_data, pre_read_rows,
can_filter_all));
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:501:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (filter_map_ptr->filter_all()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:514:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (!pre_eof) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:515:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
if (pre_raw_read_rows >= config::doris_scanner_row_num) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:520:** +1,
nesting level increased to 3
```cpp
} else { // pre_eof
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:528:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:532:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_state->is_cancelled()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:536:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (filter_map_ptr == nullptr) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:545:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_cached_filtered_rows != 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:546:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_rebuild_filter_map(filter_map, rebuild_filter_map,
pre_read_rows));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:546:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_rebuild_filter_map(filter_map, rebuild_filter_map,
pre_read_rows));
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:554:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(_read_column_data(block,
_lazy_read_ctx.lazy_read_columns, pre_read_rows,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:554:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_read_column_data(block,
_lazy_read_ctx.lazy_read_columns, pre_read_rows,
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:557:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (pre_read_rows != lazy_read_rows) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:564:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (filter_map.has_filter()) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:565:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (block->columns() == origin_column_num) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:569:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:570:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_CATCH_EXCEPTION(Block::filter_block_internal(
^
```
**be/src/common/exception.h:79:** expanded from macro
'RETURN_IF_CATCH_EXCEPTION'
```cpp
do {
\
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:570:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_CATCH_EXCEPTION(Block::filter_block_internal(
^
```
**be/src/common/exception.h:84:** expanded from macro
'RETURN_IF_CATCH_EXCEPTION'
```cpp
} catch (const doris::Exception& e) {
\
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:570:** +5,
including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_CATCH_EXCEPTION(Block::filter_block_internal(
^
```
**be/src/common/exception.h:85:** expanded from macro
'RETURN_IF_CATCH_EXCEPTION'
```cpp
if (e.code() == doris::ErrorCode::MEM_ALLOC_FAILED) {
\
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:574:** +1,
nesting level increased to 1
```cpp
} else {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:582:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = 0; i < column_num; ++i) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:584:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (column_size != 0 && cz != 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:584:** +1
```cpp
if (column_size != 0 && cz != 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:587:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (cz != 0) {
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:595:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(_fill_partition_columns(block, column_size,
_lazy_read_ctx.partition_columns));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:595:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_fill_partition_columns(block, column_size,
_lazy_read_ctx.partition_columns));
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:596:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(_fill_missing_columns(block, column_size,
_lazy_read_ctx.missing_columns));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:596:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(_fill_missing_columns(block, column_size,
_lazy_read_ctx.missing_columns));
^
```
**be/src/common/status.h:633:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
