github-actions[bot] commented on code in PR #44351:
URL: https://github.com/apache/doris/pull/44351#discussion_r1850145401
##########
be/test/olap/rowset/segment_v2/bloom_filter_index_reader_writer_test.cpp:
##########
@@ -295,5 +296,203 @@
delete[] val;
}
+TEST_F(BloomFilterIndexReaderWriterTest, test_datev2) {
+ size_t num = 1024 * 3 - 1;
+ uint32_t* val = new uint32_t[num];
+ for (size_t i = 0; i < num; ++i) {
+ val[i] = 20210101 + i; // YYYYMMDD
+ }
+
+ std::string file_name = "bloom_filter_datev2";
+ uint32_t not_exist_value = 20211231;
+
test_bloom_filter_index_reader_writer_template<FieldType::OLAP_FIELD_TYPE_DATEV2>(
+ file_name, val, num, 1, ¬_exist_value);
+ delete[] val;
+}
+
+TEST_F(BloomFilterIndexReaderWriterTest, test_datetimev2) {
+ size_t num = 1024 * 3 - 1;
+ uint64_t* val = new uint64_t[num];
+ for (size_t i = 0; i < num; ++i) {
+ val[i] = 20210101000000 + i; // YYYYMMDDHHMMSS
+ }
+
+ std::string file_name = "bloom_filter_datetimev2";
+ uint64_t not_exist_value = 20211231235959;
+
test_bloom_filter_index_reader_writer_template<FieldType::OLAP_FIELD_TYPE_DATETIMEV2>(
+ file_name, val, num, 1, ¬_exist_value);
+ delete[] val;
+}
+
+TEST_F(BloomFilterIndexReaderWriterTest, test_decimal32) {
+ size_t num = 1024 * 3 - 1;
+ int32_t* val = new int32_t[num];
Review Comment:
warning: use auto when initializing with new to avoid duplicating the type
name [modernize-use-auto]
```suggestion
auto* val = new int32_t[num];
```
##########
be/test/olap/rowset/segment_v2/bloom_filter_index_reader_writer_test.cpp:
##########
@@ -295,5 +296,203 @@
delete[] val;
}
+TEST_F(BloomFilterIndexReaderWriterTest, test_datev2) {
+ size_t num = 1024 * 3 - 1;
+ uint32_t* val = new uint32_t[num];
+ for (size_t i = 0; i < num; ++i) {
+ val[i] = 20210101 + i; // YYYYMMDD
+ }
+
+ std::string file_name = "bloom_filter_datev2";
+ uint32_t not_exist_value = 20211231;
+
test_bloom_filter_index_reader_writer_template<FieldType::OLAP_FIELD_TYPE_DATEV2>(
+ file_name, val, num, 1, ¬_exist_value);
+ delete[] val;
+}
+
+TEST_F(BloomFilterIndexReaderWriterTest, test_datetimev2) {
+ size_t num = 1024 * 3 - 1;
+ uint64_t* val = new uint64_t[num];
Review Comment:
warning: use auto when initializing with new to avoid duplicating the type
name [modernize-use-auto]
```suggestion
auto* val = new uint64_t[num];
```
##########
be/test/olap/rowset/segment_v2/bloom_filter_index_reader_writer_test.cpp:
##########
@@ -295,5 +296,203 @@
delete[] val;
}
+TEST_F(BloomFilterIndexReaderWriterTest, test_datev2) {
+ size_t num = 1024 * 3 - 1;
+ uint32_t* val = new uint32_t[num];
+ for (size_t i = 0; i < num; ++i) {
+ val[i] = 20210101 + i; // YYYYMMDD
+ }
+
+ std::string file_name = "bloom_filter_datev2";
+ uint32_t not_exist_value = 20211231;
+
test_bloom_filter_index_reader_writer_template<FieldType::OLAP_FIELD_TYPE_DATEV2>(
+ file_name, val, num, 1, ¬_exist_value);
+ delete[] val;
+}
+
+TEST_F(BloomFilterIndexReaderWriterTest, test_datetimev2) {
+ size_t num = 1024 * 3 - 1;
+ uint64_t* val = new uint64_t[num];
+ for (size_t i = 0; i < num; ++i) {
+ val[i] = 20210101000000 + i; // YYYYMMDDHHMMSS
+ }
+
+ std::string file_name = "bloom_filter_datetimev2";
+ uint64_t not_exist_value = 20211231235959;
+
test_bloom_filter_index_reader_writer_template<FieldType::OLAP_FIELD_TYPE_DATETIMEV2>(
+ file_name, val, num, 1, ¬_exist_value);
+ delete[] val;
+}
+
+TEST_F(BloomFilterIndexReaderWriterTest, test_decimal32) {
+ size_t num = 1024 * 3 - 1;
+ int32_t* val = new int32_t[num];
+ for (size_t i = 0; i < num; ++i) {
+ val[i] = static_cast<int32_t>(i * 100 + 1);
+ }
+
+ std::string file_name = "bloom_filter_decimal32";
+ int32_t not_exist_value = 99999;
+
test_bloom_filter_index_reader_writer_template<FieldType::OLAP_FIELD_TYPE_DECIMAL32>(
+ file_name, val, num, 1, ¬_exist_value);
+ delete[] val;
+}
+
+void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name,
Slice* values,
Review Comment:
warning: function 'test_ngram_bloom_filter_index_reader_writer' exceeds
recommended size/complexity thresholds [readability-function-size]
```cpp
void test_ngram_bloom_filter_index_reader_writer(const std::string&
file_name, Slice* values,
^
```
<details>
<summary>Additional context</summary>
**be/test/olap/rowset/segment_v2/bloom_filter_index_reader_writer_test.cpp:340:**
95 lines including whitespace and comments (threshold 80)
```cpp
void test_ngram_bloom_filter_index_reader_writer(const std::string&
file_name, Slice* values,
^
```
</details>
##########
be/test/olap/rowset/segment_v2/bloom_filter_index_reader_writer_test.cpp:
##########
@@ -295,5 +296,203 @@ TEST_F(BloomFilterIndexReaderWriterTest, test_decimal) {
delete[] val;
}
+TEST_F(BloomFilterIndexReaderWriterTest, test_datev2) {
+ size_t num = 1024 * 3 - 1;
+ uint32_t* val = new uint32_t[num];
Review Comment:
warning: use auto when initializing with new to avoid duplicating the type
name [modernize-use-auto]
```suggestion
auto* val = new uint32_t[num];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
