airborne12 commented on code in PR #44205:
URL: https://github.com/apache/doris/pull/44205#discussion_r1851260804
##########
be/src/olap/rowset/segment_v2/inverted_index_file_writer.cpp:
##########
@@ -443,9 +428,9 @@ InvertedIndexFileWriter::create_output_stream_v1(int64_t
index_id,
"output is nullptr.";
_CLTHROWA(CL_ERR_IO, "Create CompoundDirectory output error");
}
-
std::unique_ptr<lucene::store::IndexOutput> output(out);
- return {out_dir, std::move(output)};
+
+ return std::make_pair(std::move(out_dir_ptr), std::move(output));
Review Comment:
recommend return as follows
```
return {std::move(out_dir_ptr), std::move(output)};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
