Tobiichi-Origam1 commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1852767682
##########
be/src/olap/comparison_predicate.h:
##########
@@ -524,7 +526,7 @@ class ComparisonPredicateBase : public ColumnPredicate {
_base_loop_bit<is_nullable, is_and>(sel, size, flags,
null_map, data_array,
dict_code);
} else {
- LOG(FATAL) << "column_dictionary must use StringRef
predicate.";
+ static_assert(!std::is_same_v<T, StringRef>,
"column_dictionary must use StringRef predicate.");
Review Comment:
sorry I made a mistake here, and I have done fixing three similar errors in
this file right away
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
