cambyzju commented on code in PR #9582:
URL: https://github.com/apache/incubator-doris/pull/9582#discussion_r875855136
##########
be/src/vec/columns/column.h:
##########
@@ -183,6 +183,11 @@ class IColumn : public COW<IColumn> {
/// All data will be inserted as single element
virtual void insert_data(const char* pos, size_t length) = 0;
+ // just used for ColumnDecimal to be compatible with decimalv2
+ virtual void insert_many_decimalv2_data(const char* pos, size_t num) {
Review Comment:
`insert_many_decimalv2_data` is not a common function, it is better not add
it to IColumn.
While using, you could cast IColumn to ColumnDecimal, and call the function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
