This is an automated email from the ASF dual-hosted git repository.
gabriellee pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 5ca36a48035 [fix](runtime filter) Avoid to use ignored runtime filter
(#44708) (#44718)
5ca36a48035 is described below
commit 5ca36a48035ad6af5b05d50ef96f37a65f3b8aeb
Author: Gabriel <[email protected]>
AuthorDate: Thu Nov 28 16:40:40 2024 +0800
[fix](runtime filter) Avoid to use ignored runtime filter (#44708) (#44718)
Filter size should be set by a global size instead of a local size. This
behaviour is introduced by #43885 .
pick #44708
---
be/src/exprs/runtime_filter.cpp | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/be/src/exprs/runtime_filter.cpp b/be/src/exprs/runtime_filter.cpp
index b8032d7f0f1..f5e9c96184f 100644
--- a/be/src/exprs/runtime_filter.cpp
+++ b/be/src/exprs/runtime_filter.cpp
@@ -1121,9 +1121,6 @@ Status IRuntimeFilter::send_filter_size(RuntimeState*
state, uint64_t local_filt
std::lock_guard l(*local_merge_filters->lock);
local_merge_filters->merge_size_times--;
local_merge_filters->local_merged_size += local_filter_size;
- if (_has_local_target) {
- set_synced_size(local_filter_size);
- }
if (local_merge_filters->merge_size_times) {
return Status::OK();
} else {
@@ -1546,9 +1543,10 @@ void
IRuntimeFilter::update_runtime_filter_type_to_profile(uint64_t local_merge_
std::string IRuntimeFilter::debug_string() const {
return fmt::format(
"RuntimeFilter: (id = {}, type = {}, is_broadcast: {}, "
- "build_bf_cardinality: {}, error_msg: {}",
+ "build_bf_cardinality: {}, ignored: {}, error_msg: {}",
_filter_id, to_string(_runtime_filter_type), _is_broadcast_join,
- _wrapper->get_build_bf_cardinality(), _wrapper->_context->err_msg);
+ _wrapper->get_build_bf_cardinality(), _wrapper->is_ignored(),
+ _wrapper->_context->err_msg);
}
Status IRuntimeFilter::merge_from(const RuntimePredicateWrapper* wrapper) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]