yujun777 commented on code in PR #45081:
URL: https://github.com/apache/doris/pull/45081#discussion_r1873259232
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/PredicatesSplitter.java:
##########
@@ -102,9 +104,9 @@ public Void visit(Expression expr, Void context) {
public Predicates.SplitPredicate getSplitPredicate() {
return Predicates.SplitPredicate.of(
- equalPredicates.isEmpty() ? null :
ExpressionUtils.and(equalPredicates),
- rangePredicates.isEmpty() ? null :
ExpressionUtils.and(rangePredicates),
- residualPredicates.isEmpty() ? null :
ExpressionUtils.and(residualPredicates));
+ equalPredicates.isEmpty() ? null :
ExpressionUtils.and(Lists.newArrayList(equalPredicates)),
Review Comment:
change ExpressionUtil.and/or implementation, also change its argument type
from Collation<Expression> to List<Expression>, because new And/Or require
List<Expression>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
