morningman commented on code in PR #44277:
URL: https://github.com/apache/doris/pull/44277#discussion_r1875326266
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/FrontendsProcNode.java:
##########
@@ -223,10 +224,18 @@ private static boolean isJoin(List<InetSocketAddress>
allFeHosts, Frontend fe) {
LOG.warn("Failed to get InetAddress {}", addr);
continue;
}
- if (fe.getHost().equals(address.getHostAddress())) {
+ // Format the IP address
+ String formattedIp = formatIp(address.getHostAddress());
+
+ if (formatIp(fe.getHost()).equals(formattedIp)) {
return true;
}
}
return false;
}
+
+ private static String formatIp(String str) {
+ // Use IPAddressString to format the IP address
+ return new IPAddressString(str).getAddress().toCanonicalString();
Review Comment:
I think we should also normalized the host string when adding FE node
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
