Yukang-Lian opened a new pull request, #45197:
URL: https://github.com/apache/doris/pull/45197
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
## Problem
The current implementation of compaction task submission reserves permits
before task execution, which can lead to inefficient resource utilization.
Tasks waiting in the thread pool queue may hold permits, potentially blocking
other tasks from being executed.
## Solution
Modify the `_submit_compaction_task` method to request permits only when the
compaction task is actually about to be executed, rather than at the time of
submission to the thread pool.
## Changes
- Moved permit request from task submission to task execution stage
- Ensures permits are only held during actual task processing
- Maintains the original blocking behavior for permit acquisition
- Improves overall resource utilization across different compaction thread
pools
## Benefits
- More efficient use of system resources
- Prevents tasks from blocking permits while waiting in the queue
- Preserves the existing task scheduling logic
- No additional complexity in error handling
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
