csun5285 commented on code in PR #44994:
URL: https://github.com/apache/doris/pull/44994#discussion_r1877840167
##########
be/src/olap/tablet.cpp:
##########
@@ -2653,10 +2629,22 @@ void Tablet::gc_binlogs(int64_t version) {
// add binlog segment files and index files
for (int64_t i = 0; i < num_segments; ++i) {
-
wait_for_deleted_binlog_files.emplace_back(get_segment_filepath(rowset_id, i));
- for (const auto& index :
this->tablet_schema()->inverted_indexes()) {
- wait_for_deleted_binlog_files.emplace_back(
- get_segment_index_filepath(rowset_id, i,
index->index_id()));
+ auto segment_file_path = get_segment_filepath(rowset_id, i);
+ wait_for_deleted_binlog_files.emplace_back(segment_file_path);
+
+ // index files
+ if (tablet_schema()->get_inverted_index_storage_format() ==
+ InvertedIndexStorageFormatPB::V1) {
+ for (const auto& index : tablet_schema()->inverted_indexes()) {
+ auto index_file =
InvertedIndexDescriptor::get_index_file_path_v1(
+
InvertedIndexDescriptor::get_index_file_path_prefix(segment_file_path),
+ index->index_id(), "");
Review Comment:
ok
##########
be/src/olap/task/engine_storage_migration_task.cpp:
##########
@@ -409,8 +409,9 @@ Status
EngineStorageMigrationTask::_copy_index_and_data_files(
InvertedIndexStorageFormatPB::V1) {
for (const auto& index : tablet_schema.inverted_indexes()) {
auto index_id = index->index_id();
- auto index_file =
- _tablet->get_segment_index_filepath(rowset_id,
segment_index, index_id);
+ auto index_file =
InvertedIndexDescriptor::get_index_file_path_v1(
+
InvertedIndexDescriptor::get_index_file_path_prefix(segment_file_path),
+ index_id, "");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
