morrySnow commented on code in PR #45310:
URL: https://github.com/apache/doris/pull/45310#discussion_r1883264639
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/AddMinMax.java:
##########
@@ -326,7 +326,10 @@ private Map<Expression, MinMaxValue>
getExprMinMaxValues(UnknownValue valueDesc)
for (int i = 1; i < sourceValues.size(); i++) {
// process in sourceValues[i]
Map<Expression, MinMaxValue> minMaxValues =
getExprMinMaxValues(sourceValues.get(i));
- for (Map.Entry<Expression, MinMaxValue> entry :
minMaxValues.entrySet()) {
+ List<Map.Entry<Expression, MinMaxValue>> minMaxValueList =
minMaxValues.entrySet().stream()
+ .sorted((a, b) ->
Integer.compare(a.getValue().exprOrderIndex, b.getValue().exprOrderIndex))
+ .collect(Collectors.toList());
+ for (Map.Entry<Expression, MinMaxValue> entry : minMaxValueList) {
Review Comment:
add comment to explain why need sort by expr id
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/RangeInference.java:
##########
@@ -461,6 +475,9 @@ public boolean isAnd() {
@Override
public ValueDesc union(ValueDesc other) {
+ if (other instanceof EmptyValue) {
+ return other.union(this);
+ }
Review Comment:
add some comment to explain this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
