englefly commented on code in PR #45447:
URL: https://github.com/apache/doris/pull/45447#discussion_r1887936886
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/AggregateStrategies.java:
##########
@@ -2076,7 +2079,8 @@ private boolean couldConvertToMulti(LogicalAggregate<?
extends Plan> aggregate)
if (!func.isDistinct()) {
continue;
}
- if (!(func instanceof Count || func instanceof Sum || func
instanceof GroupConcat)) {
+ if (!(func instanceof Count || func instanceof Sum || func
instanceof GroupConcat
Review Comment:
how about add a new Interface "MultiDistinct", and let these Agg functions
implement it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
