github-actions[bot] commented on code in PR #45667:
URL: https://github.com/apache/doris/pull/45667#discussion_r1891733266
##########
be/src/vec/data_types/serde/data_type_nullable_serde.cpp:
##########
@@ -393,20 +393,21 @@ Status
DataTypeNullableSerDe::read_one_cell_from_json(IColumn& column,
return Status::OK();
}
-// void DataTypeNullableSerDe::write_one_cell_to_binary(const IColumn&
src_column,
-// ColumnString*
dst_column,
-// int64_t row_num) const
{
-// auto& col = assert_cast<const ColumnNullable&>(src_column);
-// uint8_t is_null = 0;
-// if (col.is_null_at(row_num)) [[unlikely]] {
-// is_null = 1;
-// dst_column->insert_data(reinterpret_cast<const char*>(is_null),
sizeof(uint8_t));
-// } else {
-// dst_column->insert_data(reinterpret_cast<const char*>(is_null),
sizeof(uint8_t));
-// auto& nested_col = col.get_nested_column();
-// nested_serde->write_one_cell_to_binary(nested_col, dst_column,
row_num);
-// }
-// }
+void DataTypeNullableSerDe::write_one_cell_to_binary(const IColumn& src_column,
+ ColumnString::Chars&
chars,
+ int64_t row_num) const {
+ auto& col = assert_cast<const ColumnNullable&>(src_column);
+ if (col.is_null_at(row_num)) [[unlikely]] {
+ const uint8_t type = static_cast<uint8_t>(TypeIndex::Nothing);
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the
type name [modernize-use-auto]
```suggestion
{auto
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
