gavinchou commented on code in PR #45760:
URL: https://github.com/apache/doris/pull/45760#discussion_r1895919138
##########
cloud/src/recycler/sync_executor.h:
##########
@@ -65,11 +69,27 @@ class SyncExecutor {
*finished = false;
return res;
}
- res.emplace_back((*task).get());
+ // 10s
+ size_t max_wait_time = 10000;
+ TEST_SYNC_POINT_CALLBACK("SyncExecutor::when_all.set_wait_time",
&max_wait_time);
+ // _count.timed_wait has already ensured that all tasks are
completed.
+ // The 10 seconds here is just waiting for the task results to be
returned,
+ // so 10 seconds is more than enough.
+ auto status = task->wait_for(max_wait_time);
Review Comment:
```suggestion
size_t max_wait_ms = 10000;
TEST_SYNC_POINT_CALLBACK("SyncExecutor::when_all.set_wait_time",
&max_wait_ms);
// _count.timed_wait has already ensured that all tasks are
completed.
// The 10 seconds here is just waiting for the task results to
be returned,
// so 10 seconds is more than enough.
auto status = task->wait_for(max_wait_ms);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
