HappenLee commented on code in PR #9811:
URL: https://github.com/apache/incubator-doris/pull/9811#discussion_r889856054
##########
be/src/olap/tablet_schema.h:
##########
@@ -61,9 +63,18 @@ class TabletColumn {
size_t index_length() const { return _index_length; }
void set_index_length(size_t index_length) { _index_length = index_length;
}
FieldAggregationMethod aggregation() const { return _aggregation; }
+ vectorized::AggregateFunctionPtr
get_aggregate_function(vectorized::DataTypes argument_types,
Review Comment:
better define in `.cpp` and move header of "vec" to `.cpp`
##########
be/src/vec/common/cow.h:
##########
@@ -197,10 +195,10 @@ class COW {
return ret;
}
- void swap(intrusive_ptr& rhs) {
+ void swap(const intrusive_ptr& rhs) {
Review Comment:
why change to `const&` and use `const_cast` in function, look danger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
