jackwener commented on code in PR #9993: URL: https://github.com/apache/incubator-doris/pull/9993#discussion_r892465090
########## fe/fe-core/src/main/java/org/apache/doris/nereids/properties/PhysicalProperties.java: ########## @@ -17,9 +17,20 @@ package org.apache.doris.nereids.properties; +import org.apache.doris.analysis.DistributionDesc; Review Comment: config `style` according to [doc](https://doris.apache.org/zh-CN/developer-guide/java-format-code.html#import-order) ########## fe/fe-core/src/main/java/org/apache/doris/planner/HashJoinNode.java: ########## @@ -140,6 +141,60 @@ public HashJoinNode(PlanNodeId id, PlanNode outer, PlanNode inner, TableRef inne } } + public HashJoinNode(PlanNodeId id, PlanNode outer, PlanNode inner, JoinOperator joinOp, List<Expr> eqJoinConjuncts, Review Comment: Why this PR include `planner`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
